[S] Change in coreboot[main]: mb/google/brox: Reduce PL values for booting without battery - coreboot-gerrit

11 Jul 2024


      Attention is currently required from: Eric Herrmann, Shelley Chen, Sowmya Aralguppe.
Karthik Ramasubramanian has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83406/comment/20eeec92_9e2a9a37?usp... :
PS2, Line 161: 	soc_config->tdp_pl4 -= POWER_LIMIT_TUNE;
Are you adjusting twice for PL4 - especially when PL4 > PL3? PL3 got adjusted in line 151. Is that intentional?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 2
Gerrit-Owner: Sowmya Aralguppe sowmya.aralguppe@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty deepti.deshatty@intel.com
Gerrit-Reviewer: Eric Herrmann eherrmann@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Sowmya Aralguppe sowmya.aralguppe@intel.com
Gerrit-Attention: Eric Herrmann eherrmann@google.com
Gerrit-Comment-Date: Thu, 11 Jul 2024 16:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No