Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/google/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 93:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135628):
https://review.coreboot.org/c/coreboot/+/50581/comment/b83256be_2b8536f5
PS93, Line 67: default 0xC
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 93
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rajesh Patil
rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 16 Dec 2021 12:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment