Attention is currently required from: David Wu, Paul Menzel, Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59086 )
Change subject: drivers/net/r8168: Add support for Realtek RT8125 ......................................................................
Patch Set 13: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59086/comment/2fc892e1_d1595668 PS13, Line 13: TEST=emerge-brask coreboot chromeos-bootimage. Test on brask whose NIC is : RT8125. Check if the default MAC is written into the NIC. 72 characters wide please
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/59086/comment/191a20af_d32c2ac1 PS4, Line 255: /* : * Refer to RTL8111H datasheet 7.2 Customizable LED Configuration : * Starting from offset 0x18 : * Bit[15:12] LED Feature Control(FC) : * Bit[11:08] LED Select for PINLED2 : * Bit[07:04] LED Select for PINLED1 : * Bit[03:00] LED Select for PINLED0 : * : * Speed Link10M Link100M Link1000M ACT/Full : * LED0 Bit0 Bit1 Bit2 Bit3 : * LED1 Bit4 Bit5 Bit6 Bit7 : * LED2 Bit8 Bit9 Bit10 Bit11 : * FC Bit12 Bit13 Bit14 Bit15 : */ : : /* Set customized LED registers */ : outw(config->customized_leds, io_base + CMD_LED0_LED1);
Yes. We are now working on this in commit https://review.coreboot.org/c/coreboot/+/59531.
Done
-
Tim Wawrzynczak (Code Review)