Attention is currently required from: Felix Singer, Kapil Porwal, Meera Ravindranath, Paul Menzel, Ronak Kanabar, Tarun Tuli.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75663?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vendorcode/intel: Add edk2-stable202302 support
......................................................................
Patch Set 4:
(2 comments)
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/75663/comment/1ec39087_c363b85f :
PS4, Line 207: #else
#endif
https://review.coreboot.org/c/coreboot/+/75663/comment/3b7e34e9_fe697dff :
PS4, Line 208: #error You need to implement this struct for x86_64 FSP
: #endif
:
This is not required any more as FSPM_ARCH2_UPD/ FSPS_ARCH2_UPD/FSPT_ARCH2_UPD declaration reflects support for 64 bit FSP (PLATFORM_USES_FSP2_X86_64) as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d4deab0bd1d2c6df28e067894875b80413cd905
Gerrit-Change-Number: 75663
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 09:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment