Attention is currently required from: Felix Held, Julius Werner, Maximilian Brune, Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header
......................................................................
Patch Set 6:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/24a3196f_0a9b7cb8?usp... :
PS5, Line 540: psp_directory_table *dir = directory;
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/84338/comment/cdee6d92_1cd0789a?usp... :
PS5, Line 544: uint32_t cookie = ((psp_directory_table *)directory)->header.cookie;
Do you need the extra type conversion? Can't you just use the `dir` from above?
Done
https://review.coreboot.org/c/coreboot/+/84338/comment/8e6d6256_e8c58598?usp... :
PS5, Line 549: if (directory == NULL)
You should probably do this check before dereferencing `directory` above
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84338?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7540386027c6449317e9b7c0b4fd22d09d4a3a3
Gerrit-Change-Number: 84338
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 24 Dec 2024 02:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com