[M] Change in coreboot[main]: include/assert.h: Rewrite using static inline - coreboot-gerrit

12 Sep 2024


      Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )
Change subject: include/assert.h: Rewrite using static inline
......................................................................
Patch Set 6:
(1 comment)
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/84208/comment/d90010c0_e99b79f7?usp... :
PS5, Line 28: 	(__builtin_constant_p(x) && !(CONFIG(LTO) && CONFIG(COMPILER_GCC)) ? \
...
I wonder if it would be clearer to write
#if CONFIG(LTO) && CONFIG(COMPILER_GCC)
#define __build_time_assert(x) 0
#else
#define __build_time_assert(x) (__builtin_constant_p ...
#endif

I rewrote this one to use static inline. No hacks like this are needed anymore :-)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84208?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6185e87a374f8722dba545d6bbce1c3a8de53e7e
Gerrit-Change-Number: 84208
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 10:10:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com