Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: dedede: Add dedede mainboard ......................................................................
dedede: Add dedede mainboard
Add mainboard stubs for Dedede. More functionalities will be added later.
BUG=b:144768001 TEST=Build test.
Change-Id: I7e6cb8adaee7b6bb95e9a96f96466646a78bd0fc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/Kconfig A src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/board_info.txt A src/mainboard/google/dedede/bootblock.c A src/mainboard/google/dedede/mainboard.c A src/mainboard/google/dedede/romstage.c A src/mainboard/google/dedede/variants/baseboard/devicetree.cb 8 files changed, 108 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/38277/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig new file mode 100644 index 0000000..02e4e51 --- /dev/null +++ b/src/mainboard/google/dedede/Kconfig @@ -0,0 +1,35 @@ +config BOARD_GOOGLE_BASEBOARD_DEDEDE + def_bool n + select SOC_INTEL_JASPERLAKE + +if BOARD_GOOGLE_BASEBOARD_DEDEDE + +config BASEBOARD_DEDEDE_LAPTOP + def_bool n + select SYSTEM_TYPE_LAPTOP + +config DEVICETREE + string + default "variants/baseboard/devicetree.cb" + +config MAINBOARD_DIR + string + default "google/dedede" + +config MAINBOARD_FAMILY + string + default "Google_Dedede" if BOARD_GOOGLE_DEDEDE + +config MAINBOARD_PART_NUMBER + string + default "dedede" if BOARD_GOOGLE_DEDEDE + +config MAX_CPUS + int + default 4 + +config UART_FOR_CONSOLE + int + default 2 + +endif #BOARD_GOOGLE_BASEBOARD_DEDEDE diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name new file mode 100644 index 0000000..ff5411b --- /dev/null +++ b/src/mainboard/google/dedede/Kconfig.name @@ -0,0 +1,4 @@ +config BOARD_GOOGLE_DEDEDE + bool "Dedede" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc new file mode 100644 index 0000000..be05b6b --- /dev/null +++ b/src/mainboard/google/dedede/Makefile.inc @@ -0,0 +1,5 @@ +bootblock-y += bootblock.c + +ramstage-y += mainboard.c + +subdirs-y += variants/baseboard diff --git a/src/mainboard/google/dedede/board_info.txt b/src/mainboard/google/dedede/board_info.txt new file mode 100644 index 0000000..db769af --- /dev/null +++ b/src/mainboard/google/dedede/board_info.txt @@ -0,0 +1,6 @@ +Vendor name: Google +Board name: Dedede +Category: laptop +ROM protocol: SPI +ROM socketed: n +Flashrom support: y diff --git a/src/mainboard/google/dedede/bootblock.c b/src/mainboard/google/dedede/bootblock.c new file mode 100644 index 0000000..11186f7 --- /dev/null +++ b/src/mainboard/google/dedede/bootblock.c @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <bootblock_common.h> + +void bootblock_mainboard_init(void) +{ + /* TODO: Perform mainboard initialization */ +} diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c new file mode 100644 index 0000000..51b1aa4 --- /dev/null +++ b/src/mainboard/google/dedede/mainboard.c @@ -0,0 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <device/device.h> + +static void mainboard_init(void *chip_info) +{ + /* TODO: Perform mainboard initialization */ +} + +static void mainboard_enable(struct device *dev) +{ + /* TODO: Enable mainboard */ +} + +struct chip_operations mainboard_ops = { + .init = mainboard_init, + .enable_dev = mainboard_enable, +}; diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c new file mode 100644 index 0000000..bba6e1a --- /dev/null +++ b/src/mainboard/google/dedede/romstage.c @@ -0,0 +1,15 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <fsp/api.h> +#include <soc/romstage.h> + +void mainboard_memory_init_params(FSPM_UPD *memupd) +{ + /* ToDo : Fill FSP-M memory params */ +} diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb new file mode 100644 index 0000000..eb9dc1c --- /dev/null +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -0,0 +1,5 @@ +chip soc/intel/tigerlake + device cpu_cluster 0 on + device lapic 0 on end + end +end
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: dedede: Add dedede mainboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... PS1, Line 1: chip soc/intel/tigerlake hmm. Do we want to reuse tigerlake here?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: dedede: Add dedede mainboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... PS1, Line 1: chip soc/intel/tigerlake
hmm. […]
Yes, Both Tigerlake and Jasperlake are going to follow the chip definitions in tigerlake - soc/intel/tigerlake
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: dedede: Add dedede mainboard ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... PS1, Line 1: chip soc/intel/tigerlake
Yes, Both Tigerlake and Jasperlake are going to follow the chip definitions in tigerlake - soc/intel […]
ok, thanks.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: dedede: Add dedede mainboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38277/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38277/1//COMMIT_MSG@7 PS1, Line 7: dedede mb/google
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38277
to look at the new patch set (#2).
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
mb/google/dedede: Add dedede mainboard
Add mainboard stubs for Dedede. More functionalities will be added later.
BUG=b:144768001 TEST=Build test.
Change-Id: I7e6cb8adaee7b6bb95e9a96f96466646a78bd0fc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/Kconfig A src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/board_info.txt A src/mainboard/google/dedede/bootblock.c A src/mainboard/google/dedede/chromeos.fmd A src/mainboard/google/dedede/mainboard.c A src/mainboard/google/dedede/romstage.c A src/mainboard/google/dedede/variants/baseboard/devicetree.cb 9 files changed, 156 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/38277/2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38277/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38277/1//COMMIT_MSG@7 PS1, Line 7: dedede
mb/google
Done
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38277/1/src/mainboard/google/dedede... PS1, Line 1: chip soc/intel/tigerlake
ok, thanks.
Done
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38277
to look at the new patch set (#3).
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
mb/google/dedede: Add dedede mainboard
Add mainboard stubs for Dedede. More functionalities will be added later.
BUG=b:144768001 TEST=Build test.
Change-Id: I7e6cb8adaee7b6bb95e9a96f96466646a78bd0fc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/Kconfig A src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/board_info.txt A src/mainboard/google/dedede/bootblock.c A src/mainboard/google/dedede/chromeos.fmd A src/mainboard/google/dedede/mainboard.c A src/mainboard/google/dedede/romstage.c A src/mainboard/google/dedede/variants/baseboard/devicetree.cb A src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h A src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h 11 files changed, 193 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/38277/3
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38277
to look at the new patch set (#4).
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
mb/google/dedede: Add dedede mainboard
Add mainboard stubs for Dedede. More functionalities will be added later.
BUG=b:144768001 TEST=Build test.
Change-Id: I7e6cb8adaee7b6bb95e9a96f96466646a78bd0fc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/Kconfig A src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/board_info.txt A src/mainboard/google/dedede/bootblock.c A src/mainboard/google/dedede/chromeos.fmd A src/mainboard/google/dedede/mainboard.c A src/mainboard/google/dedede/romstage.c A src/mainboard/google/dedede/variants/baseboard/devicetree.cb A src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h A src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h 11 files changed, 187 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/38277/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
Patch Set 4: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
Patch Set 4: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
Patch Set 5: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38277 )
Change subject: mb/google/dedede: Add dedede mainboard ......................................................................
mb/google/dedede: Add dedede mainboard
Add mainboard stubs for Dedede. More functionalities will be added later.
BUG=b:144768001 TEST=Build test.
Change-Id: I7e6cb8adaee7b6bb95e9a96f96466646a78bd0fc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38277 Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/dedede/Kconfig A src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/board_info.txt A src/mainboard/google/dedede/bootblock.c A src/mainboard/google/dedede/chromeos.fmd A src/mainboard/google/dedede/mainboard.c A src/mainboard/google/dedede/romstage.c A src/mainboard/google/dedede/variants/baseboard/devicetree.cb A src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h A src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h 11 files changed, 187 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Aamir Bohra: Looks good to me, approved Justin TerAvest: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig new file mode 100644 index 0000000..02e4e51 --- /dev/null +++ b/src/mainboard/google/dedede/Kconfig @@ -0,0 +1,35 @@ +config BOARD_GOOGLE_BASEBOARD_DEDEDE + def_bool n + select SOC_INTEL_JASPERLAKE + +if BOARD_GOOGLE_BASEBOARD_DEDEDE + +config BASEBOARD_DEDEDE_LAPTOP + def_bool n + select SYSTEM_TYPE_LAPTOP + +config DEVICETREE + string + default "variants/baseboard/devicetree.cb" + +config MAINBOARD_DIR + string + default "google/dedede" + +config MAINBOARD_FAMILY + string + default "Google_Dedede" if BOARD_GOOGLE_DEDEDE + +config MAINBOARD_PART_NUMBER + string + default "dedede" if BOARD_GOOGLE_DEDEDE + +config MAX_CPUS + int + default 4 + +config UART_FOR_CONSOLE + int + default 2 + +endif #BOARD_GOOGLE_BASEBOARD_DEDEDE diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name new file mode 100644 index 0000000..4bf440d --- /dev/null +++ b/src/mainboard/google/dedede/Kconfig.name @@ -0,0 +1,5 @@ +config BOARD_GOOGLE_DEDEDE + bool "Dedede" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc new file mode 100644 index 0000000..c2fc419 --- /dev/null +++ b/src/mainboard/google/dedede/Makefile.inc @@ -0,0 +1,6 @@ +bootblock-y += bootblock.c + +ramstage-y += mainboard.c + +subdirs-y += variants/baseboard +CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include diff --git a/src/mainboard/google/dedede/board_info.txt b/src/mainboard/google/dedede/board_info.txt new file mode 100644 index 0000000..db769af --- /dev/null +++ b/src/mainboard/google/dedede/board_info.txt @@ -0,0 +1,6 @@ +Vendor name: Google +Board name: Dedede +Category: laptop +ROM protocol: SPI +ROM socketed: n +Flashrom support: y diff --git a/src/mainboard/google/dedede/bootblock.c b/src/mainboard/google/dedede/bootblock.c new file mode 100644 index 0000000..11186f7 --- /dev/null +++ b/src/mainboard/google/dedede/bootblock.c @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <bootblock_common.h> + +void bootblock_mainboard_init(void) +{ + /* TODO: Perform mainboard initialization */ +} diff --git a/src/mainboard/google/dedede/chromeos.fmd b/src/mainboard/google/dedede/chromeos.fmd new file mode 100644 index 0000000..60ea3de --- /dev/null +++ b/src/mainboard/google/dedede/chromeos.fmd @@ -0,0 +1,47 @@ +FLASH@0xfe000000 0x2000000 { + SI_ALL@0x0 0x500000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x4ff000 + } + SI_BIOS@0x500000 0x1b00000 { + # Place RW_LEGACY at the start of BIOS region such that the rest + # of BIOS regions start at 16MiB boundary. Since this is a 32MiB + # SPI flash only the top 16MiB actually gets memory mapped. + RW_LEGACY(CBFS)@0x0 0xf00000 + RW_SECTION_A@0xf00000 0x3e0000 { + VBLOCK_A@0x0 0x10000 + FW_MAIN_A(CBFS)@0x10000 0x3cffc0 + RW_FWID_A@0x3dffc0 0x40 + } + RW_SECTION_B@0x12e0000 0x3e0000 { + VBLOCK_B@0x0 0x10000 + FW_MAIN_B(CBFS)@0x10000 0x3cffc0 + RW_FWID_B@0x3dffc0 0x40 + } + RW_MISC@0x16c0000 0x40000 { + UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { + RECOVERY_MRC_CACHE@0x0 0x10000 + RW_MRC_CACHE@0x10000 0x20000 + } + RW_ELOG(PRESERVE)@0x30000 0x4000 + RW_SHARED@0x34000 0x4000 { + SHARED_DATA@0x0 0x2000 + VBLOCK_DEV@0x2000 0x2000 + } + RW_VPD(PRESERVE)@0x38000 0x2000 + RW_NVRAM(PRESERVE)@0x3a000 0x6000 + } + # Make WP_RO region align with SPI vendor + # memory protected range specification. + WP_RO@0x1700000 0x400000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x3fc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0x3000 + COREBOOT(CBFS)@0x4000 0x3f8000 + } + } + } +} diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c new file mode 100644 index 0000000..51b1aa4 --- /dev/null +++ b/src/mainboard/google/dedede/mainboard.c @@ -0,0 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <device/device.h> + +static void mainboard_init(void *chip_info) +{ + /* TODO: Perform mainboard initialization */ +} + +static void mainboard_enable(struct device *dev) +{ + /* TODO: Enable mainboard */ +} + +struct chip_operations mainboard_ops = { + .init = mainboard_init, + .enable_dev = mainboard_enable, +}; diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c new file mode 100644 index 0000000..bba6e1a --- /dev/null +++ b/src/mainboard/google/dedede/romstage.c @@ -0,0 +1,15 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <fsp/api.h> +#include <soc/romstage.h> + +void mainboard_memory_init_params(FSPM_UPD *memupd) +{ + /* ToDo : Fill FSP-M memory params */ +} diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb new file mode 100644 index 0000000..eb9dc1c --- /dev/null +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -0,0 +1,5 @@ +chip soc/intel/tigerlake + device cpu_cluster 0 on + device lapic 0 on end + end +end diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h new file mode 100644 index 0000000..55faf01 --- /dev/null +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h @@ -0,0 +1,15 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef __BASEBOARD_GPIO_H__ +#define __BASEBOARD_GPIO_H__ + +#include <soc/gpe.h> +#include <soc/gpio.h> + +#endif /* __BASEBOARD_GPIO_H__ */ diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h new file mode 100644 index 0000000..b326ec0 --- /dev/null +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h @@ -0,0 +1,15 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef __BASEBOARD_VARIANTS_H__ +#define __BASEBOARD_VARIANTS_H__ + +#include <soc/gpio.h> +#include <stdint.h> + +#endif /*__BASEBOARD_VARIANTS_H__ */
-
Aamir Bohra (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)