Change in ...coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31942
to review the following change.
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256
This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios
AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply these patches: https://review.coreboot.org/c/coreboot/+/31929 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
Here are the SHA256 checksums for these AtomBIOS ROMs:
6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - for discrete GPU (dGPU) R5-M230
Save to ./coreboot/ then run ./check_atombios_roms.sh . They could be analyzed with AtomDis https://cgit.freedesktop.org/~mhopf/AtomDis/ and some other tools.
pci1002,990b.rom (for iGPU HD-8650G) has been taken from G505S with R5-M230, and despite the tiny voltage difference - it's working great for all G505S versions. https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/ GZNWISLFHUTYN6C7RTWSQUMJIFOUHMED/
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia57bc63ef27698a0f16bfdf35e2dd1414094aded --- A check_atombios_roms.sh A pci1002,6663.rom A pci1002,6665.rom A pci1002,990b.rom A sha256sums_atombios_correct.txt 5 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/31942/1
diff --git a/check_atombios_roms.sh b/check_atombios_roms.sh new file mode 100755 index 0000000..650c211 --- /dev/null +++ b/check_atombios_roms.sh @@ -0,0 +1,14 @@ +#!/bin/sh +rm -f ./sha256sums_atombios_my.txt +sha256sum ./pci1002,990b.rom > ./sha256sums_atombios_my.txt +sha256sum ./pci1002,6663.rom >> ./sha256sums_atombios_my.txt +sha256sum ./pci1002,6665.rom >> ./sha256sums_atombios_my.txt +if cmp -s "./sha256sums_atombios_my.txt" "./sha256sums_atombios_correct.txt" +then + echo "SHA256 checksums are correct. Use these AtomBIOS roms at your coreboot .config :" + echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" + exit 0 +else + echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" + exit 1 +fi diff --git a/pci1002,6663.rom b/pci1002,6663.rom new file mode 100755 index 0000000..2b3ecf5 --- /dev/null +++ b/pci1002,6663.rom Binary files differ diff --git a/pci1002,6665.rom b/pci1002,6665.rom new file mode 100755 index 0000000..87cb001 --- /dev/null +++ b/pci1002,6665.rom Binary files differ diff --git a/pci1002,990b.rom b/pci1002,990b.rom new file mode 100755 index 0000000..c56058e --- /dev/null +++ b/pci1002,990b.rom Binary files differ diff --git a/sha256sums_atombios_correct.txt b/sha256sums_atombios_correct.txt new file mode 100644 index 0000000..eb14192 --- /dev/null +++ b/sha256sums_atombios_correct.txt @@ -0,0 +1,3 @@ +6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom +6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom +15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31942 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31942/1/check_atombios_roms.sh File check_atombios_roms.sh:
https://review.coreboot.org/#/c/31942/1/check_atombios_roms.sh@8 PS1, Line 8: echo "SHA256 checksums are correct. Use these AtomBIOS roms at your coreboot .config :" line over 80 characters
https://review.coreboot.org/#/c/31942/1/check_atombios_roms.sh@9 PS1, Line 9: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters
https://review.coreboot.org/#/c/31942/1/check_atombios_roms.sh@12 PS1, Line 12: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31942 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Patch Set 1: Code-Review+1
Everything is fine :) Jenkins just did not like the commas at ROM filenames: lint-stable-023-filenames failed because its' regexp check is [^A-Za-z0-9/_.-] , that's why "X Verified". Please ignore this error and use this change if it could be useful for you.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31942 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31942/2/check_atombios_roms.sh File check_atombios_roms.sh:
https://review.coreboot.org/#/c/31942/2/check_atombios_roms.sh@8 PS2, Line 8: echo "SHA256 checksums are correct. Use these AtomBIOS roms at your coreboot .config :" line over 80 characters
https://review.coreboot.org/#/c/31942/2/check_atombios_roms.sh@9 PS2, Line 9: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters
https://review.coreboot.org/#/c/31942/2/check_atombios_roms.sh@12 PS2, Line 12: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters
Hello Mike Banon, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31942
to look at the new patch set (#3).
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256
This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios
AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply these patches: https://review.coreboot.org/c/coreboot/+/31929 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
Here are the SHA256 checksums for these AtomBIOS ROMs:
6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - for discrete GPU (dGPU) R5-M230
Save to ./coreboot/ then run ./check_atombios_roms.sh . They could be analyzed with AtomDis https://cgit.freedesktop.org/~mhopf/AtomDis/ and some other tools.
pci1002,990b.rom (for iGPU HD-8650G) has been taken from G505S with R5-M230, and despite the tiny voltage difference - it's working great for all G505S versions. https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/ GZNWISLFHUTYN6C7RTWSQUMJIFOUHMED/
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia57bc63ef27698a0f16bfdf35e2dd1414094aded --- A check_atombios_roms.sh A pci1002,6663.rom A pci1002,6665.rom A pci1002,990b.rom A sha256sums_atombios_correct.txt 5 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/31942/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31942 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31942/3/check_atombios_roms.sh File check_atombios_roms.sh:
https://review.coreboot.org/#/c/31942/3/check_atombios_roms.sh@8 PS3, Line 8: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters
https://review.coreboot.org/#/c/31942/3/check_atombios_roms.sh@9 PS3, Line 9: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters
https://review.coreboot.org/#/c/31942/3/check_atombios_roms.sh@12 PS3, Line 12: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters
mikeb mikeb has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31942 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Abandoned
There is a Gerrit critical BUG: 0 bytes for submitted binaries, impossible to download. But I already know a workaround: just convert it to text using xxd, then convert it back.
-
build bot (Jenkins) (Code Review) -
mikeb mikeb (Code Review)