Attention is currently required from: Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69275 )
Change subject: soc/amd/morgana/Kconfig: Remove TODO after review
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/morgana/Kconfig:
https://review.coreboot.org/c/coreboot/+/69275/comment/f14744d3_673417da
PS2, Line 72: select SOC_AMD_COMMON_BLOCK_PCIE_CLK_REQ # TODO: Check if this is still correct
i'd prefer to select this new kconfig option in a separate patch. if you want to keep it in this patch, please mention it in the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I598daf40a774ec81a956ce8c1aeb1cbbf4b475f3
Gerrit-Change-Number: 69275
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 10 Nov 2022 21:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment