Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36369 )
Change subject: lib/cbmem: Remove the cbmem_top_init() hook ......................................................................
lib/cbmem: Remove the cbmem_top_init() hook
This hook is unused and with the need for initializing storage to share cbmem_top over other stages gone, there is likely no future need for this.
Change-Id: I4ba9daea61b6d7b8949bbd2c4fb71d0a0fa20d93 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/include/cbmem.h M src/lib/imd_cbmem.c 2 files changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/36369/1
diff --git a/src/include/cbmem.h b/src/include/cbmem.h index c029108..0df8686 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -63,11 +63,6 @@ void cbmem_initialize_empty(void); void cbmem_initialize_empty_id_size(u32 id, u64 size);
-/* Optional hook for platforms to initialize cbmem_top() value. When employed - * it's called a single time during boot at cbmem initialization/recovery - * time. */ -void cbmem_top_init(void); - /* Return the top address for dynamic cbmem. The address returned needs to * be consistent across romstage and ramstage, and it is required to be * below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c index f04e086..d175d89 100644 --- a/src/lib/imd_cbmem.c +++ b/src/lib/imd_cbmem.c @@ -108,10 +108,6 @@ cbmem_initialize_empty_id_size(0, 0); }
-void __weak cbmem_top_init(void) -{ -} - static void cbmem_top_init_once(void) { /* Call one-time hook on expected cbmem init during boot. This sequence @@ -119,8 +115,6 @@ if (!ENV_ROMSTAGE) return;
- cbmem_top_init(); - /* The test is only effective on X86 and when address hits UC memory. */ if (ENV_X86) quick_ram_check_or_die((uintptr_t)cbmem_top() - sizeof(u32));
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36369 )
Change subject: lib/cbmem: Remove the cbmem_top_init() hook ......................................................................
Patch Set 10: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36369 )
Change subject: lib/cbmem: Remove the cbmem_top_init() hook ......................................................................
Patch Set 16: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36369 )
Change subject: lib/cbmem: Remove the cbmem_top_init() hook ......................................................................
Patch Set 22: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36369 )
Change subject: lib/cbmem: Remove the cbmem_top_init() hook ......................................................................
lib/cbmem: Remove the cbmem_top_init() hook
This hook is unused and with the need for initializing storage to share cbmem_top over other stages gone, there is likely no future need for this.
Change-Id: I4ba9daea61b6d7b8949bbd2c4fb71d0a0fa20d93 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36369 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michael Niewöhner Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/include/cbmem.h M src/lib/imd_cbmem.c 2 files changed, 0 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Aaron Durbin: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/include/cbmem.h b/src/include/cbmem.h index a22c420..cf79f41 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -63,11 +63,6 @@ void cbmem_initialize_empty(void); void cbmem_initialize_empty_id_size(u32 id, u64 size);
-/* Optional hook for platforms to initialize cbmem_top() value. When employed - * it's called a single time during boot at cbmem initialization/recovery - * time. */ -void cbmem_top_init(void); - /* Return the top address for dynamic cbmem. The address returned needs to * be consistent across romstage and ramstage, and it is required to be * below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c index 38620d2..6eb3e60 100644 --- a/src/lib/imd_cbmem.c +++ b/src/lib/imd_cbmem.c @@ -130,10 +130,6 @@ cbmem_initialize_empty_id_size(0, 0); }
-void __weak cbmem_top_init(void) -{ -} - static void cbmem_top_init_once(void) { /* Call one-time hook on expected cbmem init during boot. This sequence @@ -141,8 +137,6 @@ if (!ENV_ROMSTAGE) return;
- cbmem_top_init(); - /* The test is only effective on X86 and when address hits UC memory. */ if (ENV_X86) quick_ram_check_or_die((uintptr_t)cbmem_top() - sizeof(u32));
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)