Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, mturney mturney.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 )
Change subject: sc7180: Cleanups for drivers with common clock
......................................................................
Patch Set 3:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/56587/comment/fa699ae8_ceee9859
PS1, Line 725: .clk_div = 1, .source_div = 2},
I didn't want to clutter the common change with this target specific code. […]
Yes, this definitely needs to be merged with the clock.c change so it doesn't break in between the patches. Please also rename the argument in mdss_clock_configure() from half_divider to something else (e.g. just divider) to clarify that the doubling is done inside the function now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic334fd0d43e5b4b1e43a27d5db7665f0bc151d66
Gerrit-Change-Number: 56587
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
tdas@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 28 Jul 2021 17:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Taniya Das
tdas@codeaurora.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment