Change in coreboot[master]: dedede: modify magolor config to SPI ROM size 16MB

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44204 )


Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................

dedede: modify magolor config to SPI ROM size 16MB

modify magolor config to SPI ROM size 16MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/1

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index bfcc427..40738a0 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -59,4 +59,3 @@
 	bool "-> Magolor"
 	select BOARD_GOOGLE_BASEBOARD_DEDEDE
 	select BASEBOARD_DEDEDE_LAPTOP
-	select BOARD_ROMSIZE_KB_32768

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-MessageType: newchange

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Aug 2020 07:46:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44204

to look at the new patch set (#2).

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................

dedede: modify magolor config to SPI ROM size 16MB

modify magolor config to SPI ROM size 16MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44204

to look at the new patch set (#3).

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................

dedede: modify magolor config to SPI ROM size 16MB

modify magolor config to SPI ROM size 16MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

[Henry Sun (Code Review)]

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Aug 2020 08:59:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@7 
PS3, Line 7: dedede: modify magolor config to SPI ROM size 16MB
Nit: mb/google/dedede/var/magalor: Select 16 MB SPI ROM



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Aug 2020 16:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Aug 2020 19:16:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: dedede: modify magolor config to SPI ROM size 16MB
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@9 
PS3, Line 9: modify magolor config to SPI ROM size 16MB
1.  Maybe: Decrease the SPI ROM size from 32 MB to 16 MB
2.  Why, was the board design changed?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Aug 2020 20:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in coreboot[master]: mb/google/dedede/var/magalor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44204

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
......................................................................

mb/google/dedede/var/magalor: Select 16 MB SPI ROM

modify magolor config to SPI ROM size 16MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: mb/google/dedede/var/magalor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Marco Chen, Karthik Ramasubramanian, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44204

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
......................................................................

mb/google/dedede/var/magalor: Select 16 MB SPI ROM

Decrease the SPI ROM size from 32 MB to 16 MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: mb/google/dedede/var/magalor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@7 
PS3, Line 7: dedede: modify magolor config to SPI ROM size 16MB
> Nit: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
> OK

Change in coreboot[master]: mb/google/dedede/var/magalor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/3//COMMIT_MSG@9 
PS3, Line 9: modify magolor config to SPI ROM size 16MB
> 1.  Maybe: Decrease the SPI ROM size from 32 MB to 16 MB […]
> OK.
> the board design changed is for cost down

Change in coreboot[master]: mb/google/dedede/var/magalor: Select 16 MB SPI ROM

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: mb/google/dedede/var/magalor: Select 16 MB SPI ROM
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG@7 
PS5, Line 7: magalor
nit: mag*o*lor



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Thu, 06 Aug 2020 11:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in coreboot[master]: mb/google/dedede/var/magolor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Henry Sun, Paul Fagerburg, Angel Pons, Marco Chen, Karthik Ramasubramanian, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/44204

to look at the new patch set (#6).

Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM
......................................................................

mb/google/dedede/var/magolor: Select 16 MB SPI ROM

Decrease the SPI ROM size from 32 MB to 16 MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/44204/6
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: mb/google/dedede/var/magolor: Select 16 MB SPI ROM

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44204/5//COMMIT_MSG@7 
PS5, Line 7: magalor
> nit: mag*o*lor
> ok

Change in coreboot[master]: mb/google/dedede/var/magolor: Select 16 MB SPI ROM

[Paul Fagerburg (Code Review)]

Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44204 )

Change subject: mb/google/dedede/var/magolor: Select 16 MB SPI ROM
......................................................................

mb/google/dedede/var/magolor: Select 16 MB SPI ROM

Decrease the SPI ROM size from 32 MB to 16 MB

BUG=b:58540772
BRANCH=None
TEST= build firmware and check the magolor bin size

Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Signed-off-by: Ren Kuo <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44204
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: Angel Pons <[e-mail]>
Reviewed-by: Henry Sun <[e-mail]>
Reviewed-by: Karthik Ramasubramanian <[e-mail]>
Reviewed-by: Paul Fagerburg <[e-mail]>
---
M src/mainboard/google/dedede/Kconfig.name
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Ren Kuo: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved
  Henry Sun: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index bfcc427..40738a0 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -59,4 +59,3 @@
 	bool "-> Magolor"
 	select BOARD_GOOGLE_BASEBOARD_DEDEDE
 	select BASEBOARD_DEDEDE_LAPTOP
-	select BOARD_ROMSIZE_KB_32768

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7ddf698fde1dbf663859d5654946bc08abe737c
Gerrit-Change-Number: 44204
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Henry Sun <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Marco Chen <[e-mail]>
Gerrit-Reviewer: Paul Fagerburg <[e-mail]>
Gerrit-Reviewer: Ren Kuo <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged