[S] Change in coreboot[main]: soc/intel/common/block/cpu: Use the effective way size for NEM+

[Paul Menzel (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Jérémy Compostella, Subrata Banik.

Paul Menzel has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83946?usp=email )

Change subject: soc/intel/common/block/cpu: Use the effective way size for NEM+
......................................................................

Patch Set 10:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83946/comment/2a0f37db_5d40a632?usp... :
PS10, Line 7: NEM+
This (with +) is not mentioned in the commit message body.

https://review.coreboot.org/c/coreboot/+/83946/comment/e9e52f40_565f2c0d?usp... :
PS10, Line 7: Use the effective way size for NEM+
Maybe:
> Add Kconfig for effective way size for NEM+

https://review.coreboot.org/c/coreboot/+/83946/comment/1fe5958a_7960373b?usp... :
PS10, Line 10: the
             : way size which should be considered for No-Eviction Mode (NEM)
             : purposes
Add a comma at the end?

https://review.coreboot.org/c/coreboot/+/83946/comment/e287ba26_b136337d?usp... :
PS10, Line 21: has been
is

https://review.coreboot.org/c/coreboot/+/83946/comment/ec29808f_c5e571e6?usp... :
PS10, Line 25: TEST=Verified on PTL Intel reference platform
How? List the way size before and after?

File src/soc/intel/common/block/cpu/Kconfig:

https://review.coreboot.org/c/coreboot/+/83946/comment/9a8a1006_c420fb26?usp... :
PS10, Line 84: INTEL_CAR_ENEM_USE_EFFECTIVE_WAY_SIZE
I would misinterpret it, that platforms not selecting this use an *in*effective way size, but from your commit message that is not true as they use the MSR.

`USE_POWER_OF_TWO_WAY_SIZE`? Or something with `NO_MSR` in it?

https://review.coreboot.org/c/coreboot/+/83946/comment/10a99260_46043e42?usp... :
PS10, Line 87: On some platforms
List the known ones?

https://review.coreboot.org/c/coreboot/+/83946/comment/767603b7_aad831cd?usp... :
PS10, Line 87: the way size
             : 	  which should be considered for eNEM purposes
Add a comma at the end?