Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: gma baytrail: Add connectors support
......................................................................
Patch Set 52:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx...
File common/valleyview/hw-gfx-gma-connectors.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx...
PS50, Line 98: end Post_On;
Order is much different for the digital ports in `i915`. Have a look at […]
I'm still not sure if I should change this. For DVI and HDMI, Wait_Port_Ready works as intended.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/42359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If81b1268c69b64fa30384f629f1eb43bda15ef52
Gerrit-Change-Number: 42359
Gerrit-PatchSet: 52
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Name of user not set #1002789
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 10:08:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment