Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68584 )
Change subject: soc/amd: Define AMD_FWM_POSITION config item
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/68584/comment/9f9ef98c_9b5bfac3
PS4, Line 87: default 0xFFFA0000 if AMD_FWM_POSITION_INDEX = 0
: default 0xFFF20000 if AMD_FWM_POSITION_INDEX = 1
: default 0xFFE20000 if AMD_FWM_POSITION_INDEX = 2
: default 0xFFC20000 if AMD_FWM_POSITION_INDEX = 3
: default 0xFF820000 if AMD_FWM_POSITION_INDEX = 4
: default 0xFF020000 if AMD_FWM_POSITION_INDEX = 5
This needs to be an offset in flash, not in x86 memory mapped space?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4978a922744982afb231f8a9c650eedf950a507b
Gerrit-Change-Number: 68584
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Oct 2022 08:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment