Attention is currently required from: Matt DeVillier, Paul Menzel, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58271 )
Change subject: arch/x86/smbios: add generation of type 20 table ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58271/comment/0631c73b_cbb1fefe PS2, Line 10: type 20 Could you please explain what the "type 20" SMBIOS table is about? At least mention the name in the SMBIOS spec.
https://review.coreboot.org/c/coreboot/+/58271/comment/938cde2d_2f71e7a9 PS2, Line 10: from type 17/19 tables to generate type 20 SMBIOS table Missing a period.
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/58271/comment/cfaa9d63_7bcbbe95 PS2, Line 1038: sizeof(struct smbios_type20) Please don't. See CB:55904
https://review.coreboot.org/c/coreboot/+/58271/comment/45deb341_4135e485 PS2, Line 1042: ++ Dead increment
https://review.coreboot.org/c/coreboot/+/58271/comment/f2a8b705_3a981334 PS2, Line 1046: 0xFF nit: use lowercase for hex values
https://review.coreboot.org/c/coreboot/+/58271/comment/86d869dd_9edf0f39 PS2, Line 1051: t->length = len - 2; Please use `smbios_carve_table` added in CB:55907 and `smbios_full_table_len` added in CB:55909
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/58271/comment/a960790b_d94569e3 PS2, Line 885: u8 type; : u8 length; : u16 handle; Please use `struct smbios_header header;` instead, like the other tables do.