Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ......................................................................
Patch Set 3: Verified-1
(19 comments)
File src/soc/mediatek/mt8186/include/soc/dramc_soc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/5582d40e_991077e9 PS3, Line 7: CHANNEL_A = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/034f9252_5bff7ff1 PS3, Line 8: CHANNEL_B, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/336dde0f_3f2d96c5 PS3, Line 9: CHANNEL_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/30838127_312cd5cc PS3, Line 13: RANK_0 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/a1776f0a_023fcd65 PS3, Line 14: RANK_1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/35bd45bb_d85af5bf PS3, Line 15: RANK_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/9ebc0c58_ee9c372c PS3, Line 20: DRAM_DFS_SHUFFLE_1 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/e1c10261_edd5a85c PS3, Line 21: DRAM_DFS_SHUFFLE_2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/6979c0c8_01cfc07a PS3, Line 22: DRAM_DFS_SHUFFLE_3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/b6028f57_798f4b68 PS3, Line 23: DRAM_DFS_SHUFFLE_4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/a4c4bcca_f45c815e PS3, Line 24: DRAM_DFS_SHUFFLE_5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/36385ddd_e045f372 PS3, Line 25: DRAM_DFS_SHUFFLE_6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/c2a45f83_09139776 PS3, Line 26: DRAM_DFS_SHUFFLE_7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/b84c9031_1aa6acb4 PS3, Line 27: DRAM_DFS_SHUFFLE_8, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/2090b697_ee240213 PS3, Line 28: DRAM_DFS_SHUFFLE_9, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/5ee5d522_7af2d005 PS3, Line 29: DRAM_DFS_SHUFFLE_10, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/0862d9b7_a181c505 PS3, Line 30: DRAM_DFS_SHUFFLE_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/ed9f49f6_6c6d34d1 PS3, Line 41: CBT_NORMAL_MODE = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136078): https://review.coreboot.org/c/coreboot/+/60318/comment/bed82e82_7a885545 PS3, Line 42: CBT_BYTE_MODE1, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)