Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83419/comment/3256fc55_47d8cc9f?usp... :
PS3, Line 7: pantherlake soc
Panther Lake SOC
Done
https://review.coreboot.org/c/coreboot/+/83419/comment/2e94b8d9_4cf94b71?usp... :
PS3, Line 7: for fatcat
Redundant as already part of prefix.
Done
https://review.coreboot.org/c/coreboot/+/83419/comment/2a4d00d4_f4983f4a?usp... :
PS3, Line 9: Details:
Unneeded.
Done
https://review.coreboot.org/c/coreboot/+/83419/comment/5d2f7b85_87f746d6?usp... :
PS3, Line 10: - This patch adds initial support required to build google/fatcat
Maybe give background that google/fatcat was added with Meteor Lake support as a workaround.
Done
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/5fa7effe_eaec0792?usp... :
PS3, Line 17: select MAINBOARD_HAS_TPM2 if !SIMICS_ENV
Could we arrange the configs with !SIMICS_ENV together, for better readability.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Jul 2024 07:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org