Attention is currently required from: Anil Kumar K, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Rizwan Qureshi, Tarun.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78054?usp=email )
Change subject: soc/intel/mtl: Override SOC_INTEL_CSE_FW_PARTITION_CMOS_OFFSET
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78054/comment/9d65b0bc_924419c8 :
PS1, Line 15: ramtop
Top of RAM/Top of Memory/RAMTOP is stored at CMOS offset 100. […]
Done
https://review.coreboot.org/c/coreboot/+/78054/comment/f941da0a_1f992861 :
PS1, Line 18: 161
Fair enough, even I was thinking to override it in SoC specific Kconfig.
Done
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78054/comment/4bb292a6_2dc8749a :
PS2, Line 442: Meteorlake
nit: Intel Meteor Lake
Done
https://review.coreboot.org/c/coreboot/+/78054/comment/beffe2e5_2581f82d :
PS2, Line 443: choose the available 161 offset.
i guess you wish to convey is that offset 68 doesn't have ample free space to fit the additional siz […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78054?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8bae5245f93b99be15b4e59cfeffbc23eec95001
Gerrit-Change-Number: 78054
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 26 Sep 2023 17:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment