Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61558 )
Change subject: soc/amd/common/block/psp: introduce AMD_SOC_SEPARATE_EFS_SECTION
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/psp/efs_fmap_check.c:
https://review.coreboot.org/c/coreboot/+/61558/comment/e7c5f6b7_195a41b2
PS1, Line 7: FMAP_SECTION_FLASH_START
hmm, or should we use FLASH_BASE_ADDR here? i'm not sure if it's guaranteed that both are equivalent […]
Switched check to use (FLASH_BASE_ADDR + EFS_OFFSET) and FMAP_SECTION_EFS_START
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed0f76c9c9c9c180ee5f1b96f88689d0979bb5e
Gerrit-Change-Number: 61558
Gerrit-PatchSet: 3
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Feb 2022 20:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment