Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 )
Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c:
https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@... PS5, Line 258: void *chip_info No need for `void *` here, just give it the correct type please.
https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@... PS5, Line 261: = NULL The initialization is unnecessary and compilers might even warn about it.
https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@... PS5, Line 292: if (config) { Check in pch_pcie_enable() instead please.
https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@... PS5, Line 313: If you really want to check `config` for `NULL`, do it here and just `return` in case. By the time you check it in pci_pcie_devicetree_update() it's already been dereferenced multiple times.