HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43343 )
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
soc/intel/braswell/romstage/romstage.c: Add missing include
Replace unused <stddef.h> by missing <stdint.h>.
Change-Id: I43b8ba5849de30e2ee253382ef85b17f2d0ae589 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/braswell/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/43343/1
diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index 77d13c4..b6b20b9 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <cbmem.h> -#include <stddef.h> +#include <stdint.h> #include <arch/io.h> #include <device/mmio.h> #include <console/console.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43343 )
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43343/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43343/1//COMMIT_MSG@9 PS1, Line 9: by with
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43343
to look at the new patch set (#2).
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
soc/intel/braswell/romstage/romstage.c: Add missing include
Replace unused <stddef.h> with missing <stdint.h>.
Change-Id: I43b8ba5849de30e2ee253382ef85b17f2d0ae589 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/braswell/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/43343/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43343 )
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43343/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43343/1//COMMIT_MSG@9 PS1, Line 9: by
with
Thx
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43343 )
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43343 )
Change subject: soc/intel/braswell/romstage/romstage.c: Add missing include ......................................................................
soc/intel/braswell/romstage/romstage.c: Add missing include
Replace unused <stddef.h> with missing <stdint.h>.
Change-Id: I43b8ba5849de30e2ee253382ef85b17f2d0ae589 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43343 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/braswell/romstage/romstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index 77d13c4..b6b20b9 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <cbmem.h> -#include <stddef.h> +#include <stdint.h> #include <arch/io.h> #include <device/mmio.h> #include <console/console.h>