Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 53:
(40 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/4246174f_c03fd201 PS53, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/ed69a9c2_ded34547 PS53, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/7e18857f_204432b9 PS53, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/31a4374b_05c5a25b PS53, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/213322b9_cbd0b999 PS53, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/2f2615e5_de887890 PS53, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/279c26b6_e14be1a1 PS53, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/bff05797_0ba5ace8 PS53, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/52c30ae7_46c1420a PS53, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/4433b884_ad84d5a1 PS53, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/f676436b_b98e0f6b PS53, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/b55f687e_b5e61a3a PS53, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/9e843730_20d5b0b4 PS53, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/c012df2c_cc45103d PS53, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/b67a5ee1_bfd2b652 PS53, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/7453c075_67835850 PS53, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/08dcf954_ad42515b PS53, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/7eaaea99_9a14f397 PS53, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/c3f2615b_ed5049cb PS53, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/7d96afa8_4d18a307 PS53, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/919ce6fb_31a62cd3 PS53, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/3aa2ea9d_88abd213 PS53, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/393c3e2d_eba716f0 PS53, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/54533421_2ccb7c5a PS53, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/ad6d103d_ee023834 PS53, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/1ce06457_7174edde PS53, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/70b7fb47_e11f4173 PS53, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/068e53cc_4727145c PS53, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/861e4c03_a03367b8 PS53, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/12e8c4f2_2af8e432 PS53, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/40cd0fca_ae23516a PS53, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/bc77fdd4_9690ac53 PS53, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/07963a10_75628f64 PS53, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/36df7a8c_f19755cc PS53, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/7b9ef58c_5d9481a3 PS53, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/3607faca_ffa82b0a PS53, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/18b44513_8fda6f78 PS53, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/326cda51_f6641b77 PS53, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/6c8f29d4_9421904e PS53, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159857): https://review.coreboot.org/c/coreboot/+/23586/comment/c0c17e48_c5fd76bb PS53, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)