Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48960 )
Change subject: soc/intel/skylake: Add GFX0 ACPI device ......................................................................
soc/intel/skylake: Add GFX0 ACPI device
Include gfx.asl for Skylake/Kabylake, since all other soc/intel/common platforms already do. Adjust graphics.asl for mb/51nb/x210 to prevent device redefinition.
Change-Id: I977085ccd3003cc1f84bfe65bc0d39c56c6f0a15 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/51nb/x210/acpi/graphics.asl M src/soc/intel/skylake/acpi/pch.asl 2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48960/1
diff --git a/src/mainboard/51nb/x210/acpi/graphics.asl b/src/mainboard/51nb/x210/acpi/graphics.asl index e703ba1..4a5672c 100644 --- a/src/mainboard/51nb/x210/acpi/graphics.asl +++ b/src/mainboard/51nb/x210/acpi/graphics.asl @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-Device (GFX0) +Scope (GFX0) { - Name (_ADR, 0x00020000) + Method (_DOS, 1, NotSerialized) { /* We never do anything in firmware, so _DOS is a noop */ diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index 6eea5bb..02e30f7 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -65,3 +65,6 @@ #if CONFIG(SOC_INTEL_COMMON_BLOCK_SGX) #include <soc/intel/common/acpi/sgx.asl> #endif + +/* Integrated graphics 0:2.0 */ +#include <drivers/intel/gma/acpi/gfx.asl>
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48960 )
Change subject: soc/intel/skylake: Add GFX0 ACPI device ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48960 )
Change subject: soc/intel/skylake: Add GFX0 ACPI device ......................................................................
Patch Set 2:
(1 comment)
Just squash it? I don't see a difference to the other platforms handled in the follow up.
https://review.coreboot.org/c/coreboot/+/48960/2/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/pch.asl:
PS2: There's a `systemagent.asl` that would match better.
Hello build bot (Jenkins), Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48960
to look at the new patch set (#3).
Change subject: drivers/intel/gma: Include gfx.asl by default for all platforms... ......................................................................
drivers/intel/gma: Include gfx.asl by default for all platforms...
which select INTEL_GMA_ACPI. Rework brightness level includes and platform-level asl files to avoid duplicate device definition for GFX0.
Include gfx.asl for Skylake/Kabylake, since all other soc/intel/common platforms already do. Adjust mb/51nb/x210 to prevent device redefinition.
Some OSes (eg, Windows, MacOS) require/prefer the ACPI device for the IGD to exist, even if ACPI brightness controls are not utilized. This change adds a GFX0 ACPI device for all boards whose platforms select INTEL_GMA_ACPI without requiring non-functional brightness controls to be added at the board level.
Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0 Signed-off-by: Matt DeVillier matt.devillier@gmail.com
soc/intel/skylake: Add GFX0 ACPI device
Change-Id: I977085ccd3003cc1f84bfe65bc0d39c56c6f0a15 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/intel/gma/acpi/gma.asl M src/mainboard/51nb/x210/acpi/graphics.asl M src/northbridge/intel/gm45/acpi/gm45.asl M src/northbridge/intel/haswell/acpi/hostbridge.asl M src/northbridge/intel/i945/acpi/i945.asl M src/northbridge/intel/i945/acpi/igd.asl M src/northbridge/intel/ironlake/acpi/ironlake.asl M src/northbridge/intel/pineview/acpi/pineview.asl M src/northbridge/intel/sandybridge/acpi/sandybridge.asl M src/northbridge/intel/x4x/acpi/x4x.asl M src/soc/intel/baytrail/acpi/southcluster.asl M src/soc/intel/braswell/acpi/southcluster.asl M src/soc/intel/broadwell/acpi/hostbridge.asl M src/soc/intel/skylake/acpi/pch.asl 14 files changed, 35 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48960/3
Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48960 )
Change subject: drivers/intel/gma: Include gfx.asl by default for all platforms... ......................................................................
Abandoned
squashed into CB:48862