Attention is currently required from: Eric Lai, Subrata Banik, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75912?usp=email )
Change subject: mb/google/hades: Update typeC usb PLD
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/hades/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75912/comment/7dc67e99_db18598e :
PS3, Line 292: RIGHT
oh should be rear, sorry for my English.
Isn't the form factor is clamshell for hades?
Still the PLDs should be same/identical for `tcss_usb3_port1` and `usb2_port3`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75912?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97517ecd4f8615af749fb6d007ded8e171796f7c
Gerrit-Change-Number: 75912
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 12:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment