Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
......................................................................
Patch Set 18:
(2 comments)
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/5d018552_f2d51903?usp... :
PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs");
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/85128/comment/4880d03e_95ad8e5d?usp... :
PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs");
`please, no spaces at the start of a line` […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a
Gerrit-Change-Number: 85128
Gerrit-PatchSet: 18
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 05 Dec 2024 07:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com