Attention is currently required from: Arthur Heymans, Felix Singer, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
David Hendricks has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83327?usp=email )
Change subject: mb/intel/beechnutcity_crb: Update SMBIOS type 0,1,2,3 info
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/mainboard/intel/beechnutcity_crb/Kconfig:
https://review.coreboot.org/c/coreboot/+/83327/comment/b7fa84cf_f368dc0e?usp... :
PS3, Line 21: config CARDBUS_PLUGIN_SUPPORT
Redundant with the above config option.
Also, why is this an option? I thought cardbus was long obsolete, and I don't see it mentioned in any BHS documents. Maybe I'm thinking of the wrong thing...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83327?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a7d4958171df121e2cd3acb3a71554c695d64ab
Gerrit-Change-Number: 83327
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 22:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes