HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43692 )
Change subject: cpu/intel/model_206ax: Clean up inculdes ......................................................................
cpu/intel/model_206ax: Clean up inculdes
Change-Id: I5dc2e7b327278c281087c7461e62569aab3fe450 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_206ax/acpi.c M src/cpu/intel/model_206ax/common.c M src/cpu/intel/model_206ax/finalize.c 3 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/43692/1
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index 9ff0673..13ee20a 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <types.h> #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> @@ -9,6 +8,8 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> +#include <stdint.h> + #include "model_206ax.h" #include "chip.h"
diff --git a/src/cpu/intel/model_206ax/common.c b/src/cpu/intel/model_206ax/common.c index a881314..7e27c14 100644 --- a/src/cpu/intel/model_206ax/common.c +++ b/src/cpu/intel/model_206ax/common.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <cpu/x86/msr.h> -#include "model_206ax.h"
int get_platform_id(void) { diff --git a/src/cpu/intel/model_206ax/finalize.c b/src/cpu/intel/model_206ax/finalize.c index c7579f1..37fbefd 100644 --- a/src/cpu/intel/model_206ax/finalize.c +++ b/src/cpu/intel/model_206ax/finalize.c @@ -2,7 +2,6 @@
#include <arch/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/intel/speedstep.h> #include "model_206ax.h"
/* MSR Documentation based on
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43692
to look at the new patch set (#3).
Change subject: cpu/intel/model_206ax: Clean up includes ......................................................................
cpu/intel/model_206ax: Clean up includes
Change-Id: I5dc2e7b327278c281087c7461e62569aab3fe450 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_206ax/acpi.c M src/cpu/intel/model_206ax/common.c M src/cpu/intel/model_206ax/finalize.c 3 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/43692/3
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43692
to look at the new patch set (#4).
Change subject: cpu/intel/model_206ax: Clean up includes ......................................................................
cpu/intel/model_206ax: Clean up includes
Change-Id: I5dc2e7b327278c281087c7461e62569aab3fe450 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_206ax/acpi.c M src/cpu/intel/model_206ax/finalize.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/43692/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43692 )
Change subject: cpu/intel/model_206ax: Clean up includes ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43692 )
Change subject: cpu/intel/model_206ax: Clean up includes ......................................................................
cpu/intel/model_206ax: Clean up includes
Change-Id: I5dc2e7b327278c281087c7461e62569aab3fe450 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43692 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_206ax/acpi.c M src/cpu/intel/model_206ax/finalize.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index 9ff0673..13ee20a 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <types.h> #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> @@ -9,6 +8,8 @@ #include <cpu/intel/speedstep.h> #include <cpu/intel/turbo.h> #include <device/device.h> +#include <stdint.h> + #include "model_206ax.h" #include "chip.h"
diff --git a/src/cpu/intel/model_206ax/finalize.c b/src/cpu/intel/model_206ax/finalize.c index c7579f1..37fbefd 100644 --- a/src/cpu/intel/model_206ax/finalize.c +++ b/src/cpu/intel/model_206ax/finalize.c @@ -2,7 +2,6 @@
#include <arch/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/intel/speedstep.h> #include "model_206ax.h"
/* MSR Documentation based on
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)