Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61432 )
Change subject: Redrix4es: remove unwanted entries in devicetree ......................................................................
Redrix4es: remove unwanted entries in devicetree
Signed-off-by: Anil Kumar anil.kumar.k@intel.com Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23 --- M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/redrix4es/gpio.c M src/mainboard/google/brya/variants/redrix4es/overridetree.cb 3 files changed, 14 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/61432/1
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index ee0fbce..537bc9f 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -23,18 +23,20 @@ register "CnviBtCore" = "true"
register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C0 - register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC1)" # USB2_C1 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" # USB2_C1 register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC2)" # USB2_C2 - register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # M.2 WWAN + register "usb2_ports[3]" = "USB2_PORT_EMPTY" # M.2 WWAN + register "usb2_ports[4]" = "USB2_PORT_EMPTY" + register "usb2_ports[6]" = "USB2_PORT_EMPTY" register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Camera register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # M.2 Bluetooth
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC3)" # USB3/2 Type A port A0 - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # M.2 WWAN + register "usb3_ports[3]" = "USB3_PORT_EMPTY" # M.2 WWAN
register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC0)" - register "tcss_ports[1]" = "TCSS_PORT_DEFAULT(OC1)" + register "tcss_ports[1]" = "TCSS_PORT_EMPTY" register "tcss_ports[2]" = "TCSS_PORT_DEFAULT(OC2)"
register "SerialIoI2cMode" = "{ diff --git a/src/mainboard/google/brya/variants/redrix4es/gpio.c b/src/mainboard/google/brya/variants/redrix4es/gpio.c index afcb7e9..07d85d2 100644 --- a/src/mainboard/google/brya/variants/redrix4es/gpio.c +++ b/src/mainboard/google/brya/variants/redrix4es/gpio.c @@ -53,7 +53,7 @@ /* H20 : IMGCLKOUT1 ==> NC */ PAD_NC(GPP_H20, NONE), /* H21 : IMGCLKOUT2 ==> Privacy screen */ - PAD_CFG_GPO(GPP_H21, 0, DEEP), + PAD_NC(GPP_H21, NONE),
/* R6 : I2S_PCH_TX_SPKR_RX ==> NC */ PAD_NC(GPP_R6, NONE), diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index 72f1da2..4e48d4b 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -32,63 +32,21 @@ end chip soc/intel/alderlake register "SaGv" = "SaGv_Enabled" - register "CnviBtAudioOffload" = "true" + #register "CnviBtAudioOffload" = "true" + register "PsysPmax" = "143" # FIVR RFI Spread Spectrum 6% - register "FivrSpreadSpectrum" = "FIVR_SS_6" + register "TcssAuxOri" = "1" + #register "FivrSpreadSpectrum" = "FIVR_SS_6"
# Acoustic settings register "AcousticNoiseMitigation" = "1" register "SlowSlewRate[VR_DOMAIN_IA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "FastPkgCRampDisable[VR_DOMAIN_GT]" = "1" register "FastPkgCRampDisable[VR_DOMAIN_IA]" = "1"
- # Intel Common SoC Config - #+-------------------+---------------------------+ - #| Field | Value | - #+-------------------+---------------------------+ - #| GSPI1 | Fingerprint MCU | - #| I2C0 | Audio | - #| I2C1 | Touchscreen | - #| I2C2 | | - #| I2C3 | cr50 TPM. Early init is | - #| | required to set up a BAR | - #| | for TPM communication | - #| I2C5 | Trackpad | - #+-------------------+---------------------------+ - register "common_soc_config" = "{ - .i2c[0] = { - .speed = I2C_SPEED_FAST, - }, - .i2c[1] = { - .speed = I2C_SPEED_FAST, - }, - .i2c[2] = { - .speed = I2C_SPEED_FAST, - }, - .i2c[3] = { - .early_init = 1, - .speed = I2C_SPEED_FAST, - }, - .i2c[5] = { - .speed = I2C_SPEED_FAST, - }, - }" register "tcc_offset" = "3" # TCC of 97C device domain 0 on - device ref igpu on - chip drivers/gfx/generic - register "device_count" = "1" - register "device[0].name" = ""LCD"" - # Use Chrome OS privacy screen _HID - register "device[0].hid" = ""GOOG0010"" - # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" - register "device[0].privacy.enabled" = "1" - register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" - device generic 0 on - probe EPS PRIVACY_SCREEN - end - end - end # Integrated Graphics Device device ref dtt on chip drivers/intel/dptf ## sensor information @@ -147,7 +105,7 @@ end device ref cnvi_wifi on chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + #register "wake" = "GPE0_PME_B0" device generic 0 on end end end @@ -477,11 +435,6 @@ device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""USB2 WWAN"" - register "type" = "UPC_TYPE_INTERNAL" - device ref usb2_port4 on end - end - chip drivers/usb/acpi register "desc" = ""USB2 Camera"" register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port6 on end @@ -505,11 +458,6 @@ register "group" = "ACPI_PLD_GROUP(4, 1)" device ref usb3_port1 on end end - chip drivers/usb/acpi - register "desc" = ""USB3 WWAN"" - register "type" = "UPC_TYPE_INTERNAL" - device ref usb3_port4 on end - end end end end