Attention is currently required from: Henry Sun, Paul Menzel, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60245 )
Change subject: mb/google/dedede/var/beadrix: Configure GPIO settings
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/mainboard/google/dedede/variants/beadrix/gpio.c:
https://review.coreboot.org/c/coreboot/+/60245/comment/03037849_9dc00796
PS2, Line 60: PAD_NC(GPP_H1, NONE),
It seems SD Card is not going to be supported. […]
I have created a new CL.
https://review.coreboot.org/c/coreboot/+/60266
https://review.coreboot.org/c/coreboot/+/60245/comment/128533b4_ee507536
PS2, Line 63: /* TODO; static const struct pad_config lte_disable_pads[] = {
: PAD_NC(GPP_A10, NONE),
: PAD_NC(GPP_D0, NONE),
: PAD_NC(GPP_H17, NONE),
: }; */
Remove the TODO. Same comment for line 75 - 81.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53fc8088ff8ebb2790ac8cd68186cf9de908b414
Gerrit-Change-Number: 60245
Gerrit-PatchSet: 3
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 21 Dec 2021 02:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment