Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Isaac Lee, Chris Wang, Martin Roth, Fred Reitberger, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73123 )
Change subject: soc/amd/mendocino: Add new 'STT_ALPHA_APU' parameter for DPTC support
......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/73123/comment/fc0dfd24_d5d8cdc2
PS1, Line 50: register "stt_alpha_apu_B" = "0x6666"
Since they are all the same value, remove all of these versions and just reference `stt_alpha_apu`. For example, see `vrm_current_limit_mA` which is reused for all thermal tables.
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/73123/comment/e15c61ac_06c18b8b
PS1, Line 77: uint16_t stt_m1_tablet;
: uint16_t stt_m2_tablet;
: uint16_t stt_c_apu_tablet;
Why are these being added?
https://review.coreboot.org/c/coreboot/+/73123/comment/99f3f19d_de58bd71
PS1, Line 80: uint16_t stt_alpha_apu_tablet;
Where is this being set?
https://review.coreboot.org/c/coreboot/+/73123/comment/859e07f1_b39fb190
PS1, Line 91: uint16_t stt_alpha_apu_B;
Same as above. Unnecessary, so remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib27572712d57585f66030d9e927896a8249e97a7
Gerrit-Change-Number: 73123
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Edward Dai
edwarddai@google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 21 Feb 2023 22:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment