Change in coreboot[master]: soc/amd/common/fsp: check fsp image revision

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61281 )

Change subject: soc/amd/common/fsp: check fsp image revision
......................................................................

Patch Set 10:

(3 comments)

File src/soc/amd/common/fsp/fsp_validate.c:

https://review.coreboot.org/c/coreboot/+/61281/comment/e830f5aa_a9183986 
PS10, Line 12: };
since this is used to deserialize data, i'd add a __packed attribute just to be sure that the compiler won't do anything unexpected

https://review.coreboot.org/c/coreboot/+/61281/comment/01c386b8_2baed503 
PS10, Line 47: 		" build's FspmUpd.h\n");
i'd indent this line

https://review.coreboot.org/c/coreboot/+/61281/comment/34c76f12_b4b5188f 
PS10, Line 51: printk(BIOS_ERR, "IMAGE_REVISION_MAJOR_VERSION mismatch, halting\n");
             : 		die("Goodbye now\n");
put the message from the printk line in the die call?