Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Shelley Chen.
Julius Werner has posted comments on this change by Ashish Kumar Mishra. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Is there really a platform where the most efficient compression algorithm for ramstage is LZMA but for the logo is LZ4? They get loaded under very similar conditions, so usually what's best for one should be best for the other.
I'd prefer to avoid having separate compression Kconfigs for every single file that all do their own thing. There should usually be a single answer per platform which algorithm is better that applies the same to all post-RAM files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83420?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57fbd0d3a39eaba3fb9d61e7a3fb5eeb44e3a839
Gerrit-Change-Number: 83420
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 11 Jul 2024 19:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No