Change in coreboot[master]: mb/google/brya/var/taeko:Remove duplicate DB_SD fw_config fields. - coreboot-gerrit

2 Jan 2022


      Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60409 )
Change subject: mb/google/brya/var/taeko:Remove duplicate DB_SD fw_config fields.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60409/comment/9fa79b25_39d809ce 
PS1, Line 9: Since fw config fields for DB_SD can share the same driver, we will remove the
           : duplicate fields DB_SD_GL9750 and DB_SD_RTS5232S.
72 characters wide, please.
also have you considered renaming the field to DB_SD_PRESENT or similar?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60409
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7814c35f63fd6fa27195d448c4d51fc980aaa9c
Gerrit-Change-Number: 60409
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Joey Peng joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Sun, 02 Jan 2022 20:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment