Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20075 )
Change subject: mainboard/intel/cannonlake_rvp: Initial set of board files ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/20075/1/src/mainboard/intel/cannonlake_rvp/K... File src/mainboard/intel/cannonlake_rvp/Kconfig:
https://review.coreboot.org/#/c/20075/1/src/mainboard/intel/cannonlake_rvp/K... PS1, Line 28: bs/mainboard/$(CONFIG_MAINBOARD_DIR)/me.bin" Do we need to add the EC_BIN here?