Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36659 )
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
cpu/intel/gen1/smmrelocate: Fix stale comment
Change-Id: I91ed5f7cbcfa5c510bb8e74049ec860397d7dbba Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/36659/1
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index 5350d1c..e3f934d 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -11,8 +11,7 @@ * GNU General Public License for more details. */
-/* SMM relocation with intention to work for i945-ivybridge. - Right now used for sandybridge and ivybridge. */ +/* SMM relocation for i945-ivybridge. */
#include <assert.h> #include <types.h>
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36659 )
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36659 )
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36659 )
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
Patch Set 3: Code-Review+2
Hello Kyösti Mälkki, Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36659
to look at the new patch set (#4).
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
cpu/intel/gen1/smmrelocate: Fix stale comment
Change-Id: I91ed5f7cbcfa5c510bb8e74049ec860397d7dbba Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/36659/4
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36659 )
Change subject: cpu/intel/gen1/smmrelocate: Fix stale comment ......................................................................
cpu/intel/gen1/smmrelocate: Fix stale comment
Change-Id: I91ed5f7cbcfa5c510bb8e74049ec860397d7dbba Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36659 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index c177e9b..834ec04 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -11,8 +11,7 @@ * GNU General Public License for more details. */
-/* SMM relocation with intention to work for i945-ivybridge. - Right now used for sandybridge and ivybridge. */ +/* SMM relocation for i945-ivybridge. */
#include <assert.h> #include <types.h>
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)