Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58180 )
Change subject: mb/google/brya: Clear SLP_S0_GATE_L on S5 shutdown
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/58180/comment/0b0d5fe0_843833c8
PS1, Line 30: S5 shutdown
This is not just S5 shutdown but any sleep entry, right?
Also, how does this work in case of S0ix? Is _PTS called in that case too?
https://review.coreboot.org/c/coreboot/+/58180/comment/34570004_297da4a2
PS1, Line 33: */
Add comment that this gets reconfigured correctly on wake from sleep path i.e. in ramstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
Gerrit-Change-Number: 58180
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 07 Oct 2021 18:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment