Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76038?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for LanWakeFromDeepSx dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for LanWakeFromDeepSx dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="LanWakeFromDeepSx" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I218ca92e7ebdc1d87be4c243d5209bc9436fac01 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/76038/1
diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 6133586..696d822 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -52,7 +52,7 @@ # Enable DDC for DDI port B register DdiPortBDdc = true
- register "LanWakeFromDeepSx" = "0" + register LanWakeFromDeepSx = false register "WolEnableOverride" = "0"
# VR Settings Configuration for 4 Domains