Attention is currently required from: Felix Held, Felix Singer.
Hello Felix Singer, build bot (Jenkins), Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/83375?usp=email
to review the following change.
Change subject: Revert "Makefile.mk: Remove bc dependency" ......................................................................
Revert "Makefile.mk: Remove bc dependency"
This reverts commit 4a8d73d6a4af625f97af908911478d481b95b461.
Reason for revert: expr does not support shifting.
Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/83375/1
diff --git a/Makefile.mk b/Makefile.mk index 592365e..68fc8c9 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -178,7 +178,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) -int-shift-left=$(shell expr $(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1))) +int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) < $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) > $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1))))
-
Maximilian Brune (Code Review)