Attention is currently required from: Rex-BC Chen, Paul Menzel. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 6:
(2 comments)
File src/soc/mediatek/mt8186/devapc.c:
https://review.coreboot.org/c/coreboot/+/60317/comment/b3feb887_446122cb PS6, Line 1283: Remove blank line
File src/soc/mediatek/mt8186/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/60317/comment/b8ff64aa_87cfda8f PS6, Line 70: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ : PERM_ATTR2, PERM_ATTR3) \ : (unsigned char)PERM_ATTR0, (unsigned char)PERM_ATTR1, \ : (unsigned char)PERM_ATTR2, (unsigned char)PERM_ATTR3, : : #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ : PERM_ATTR2, PERM_ATTR3, PERM_ATTR4, PERM_ATTR5, \ : PERM_ATTR6, PERM_ATTR7) \ : DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ : PERM_ATTR2, PERM_ATTR3) \ : DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR4, PERM_ATTR5, \ : PERM_ATTR6, PERM_ATTR7) : : #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ : PERM_ATTR2, PERM_ATTR3, PERM_ATTR4, PERM_ATTR5, \ : PERM_ATTR6, PERM_ATTR7, PERM_ATTR8, PERM_ATTR9, \ : PERM_ATTR10, PERM_ATTR11, PERM_ATTR12, PERM_ATTR13, \ : PERM_ATTR14, PERM_ATTR15) \ : DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ : PERM_ATTR2, PERM_ATTR3, \ : PERM_ATTR4, PERM_ATTR5, \ : PERM_ATTR6, PERM_ATTR7) \ : DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR8, PERM_ATTR9, \ : PERM_ATTR10, PERM_ATTR11, \ : PERM_ATTR12, PERM_ATTR13, \ : PERM_ATTR14, PERM_ATTR15) : : #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN : #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN : #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN : #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN : #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN : : #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Can we move these to a common header file (to be shared with mt8195)?