Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74770?usp=email )
Change subject: mainboard/google/rex: Enable crashlog
......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74770/comment/3527c433_eb080223 :
PS18, Line 10: shared_sram
please mention which SRAM is for IOE and PMC
Done
https://review.coreboot.org/c/coreboot/+/74770/comment/6914a816_fc3fba88 :
PS18, Line 13: Bug
BUG
Done
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74770/comment/ffc17e1f_b86ad373 :
PS18, Line 838: device shared_sram2 on end
device ref shared_sram2 on end <--- move this line at 352
Done
https://review.coreboot.org/c/coreboot/+/74770/comment/87dc8c90_d613e789 :
PS18, Line 839: device shared_sram on end
device ref shared_sram on end <--- move this line at 415
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74770?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d3a9fb41d1293f021ad9de9b29c756cb7559373
Gerrit-Change-Number: 74770
Gerrit-PatchSet: 18
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Jun 2023 02:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment