Change in coreboot[master]: binaryPI: Disable boards from build

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

binaryPI: Disable boards from build

As per the 4.11 release requirement, POSTCAR_STAGE=y
is a mandatory feature, which binaryPI currently lacks.

Disable all binaryPI platforms from the build for the
moment. If a platform does not reach POSTCAR_STAGE=y and
C_ENVIRONMENT_BOOTBLOCK=y within a reasonable timeframe
both the mainboard and the respective (now unused) platform
support code will get removed.

Change-Id: Id81ab0f168034187ecf62203b5a33ac6ba49a35d
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/bettong/Kconfig
M src/mainboard/amd/bettong/Kconfig.name
M src/mainboard/amd/db-ft3b-lc/Kconfig
M src/mainboard/amd/db-ft3b-lc/Kconfig.name
M src/mainboard/amd/lamar/Kconfig
M src/mainboard/amd/lamar/Kconfig.name
M src/mainboard/amd/olivehillplus/Kconfig
M src/mainboard/amd/olivehillplus/Kconfig.name
M src/mainboard/bap/ode_e21XX/Kconfig
M src/mainboard/bap/ode_e21XX/Kconfig.name
M src/mainboard/pcengines/apu2/Kconfig
M src/mainboard/pcengines/apu2/Kconfig.name
12 files changed, 53 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/37170/1

diff --git a/src/mainboard/amd/bettong/Kconfig b/src/mainboard/amd/bettong/Kconfig
index eaebfb5..fd4650f 100644
--- a/src/mainboard/amd/bettong/Kconfig
+++ b/src/mainboard/amd/bettong/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_BETTONG
+	def_bool n
+
 if BOARD_AMD_BETTONG

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/bettong/Kconfig.name b/src/mainboard/amd/bettong/Kconfig.name
index 09201b5..4bd1329 100644
--- a/src/mainboard/amd/bettong/Kconfig.name
+++ b/src/mainboard/amd/bettong/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_BETTONG
-	bool "Bettong"
+# Disabled
+#config BOARD_AMD_BETTONG
+#	bool "Bettong"
diff --git a/src/mainboard/amd/db-ft3b-lc/Kconfig b/src/mainboard/amd/db-ft3b-lc/Kconfig
index ffb3f10..34df2e9 100644
--- a/src/mainboard/amd/db-ft3b-lc/Kconfig
+++ b/src/mainboard/amd/db-ft3b-lc/Kconfig
@@ -14,6 +14,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_DB_FT3B_LC
+	def_bool n
+
 if BOARD_AMD_DB_FT3B_LC

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/db-ft3b-lc/Kconfig.name b/src/mainboard/amd/db-ft3b-lc/Kconfig.name
index 7caf95d..3197a70 100644
--- a/src/mainboard/amd/db-ft3b-lc/Kconfig.name
+++ b/src/mainboard/amd/db-ft3b-lc/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_DB_FT3B_LC
-	bool "DB-FT3b-LC"
+# Disabled
+#config BOARD_AMD_DB_FT3B_LC
+#	bool "DB-FT3b-LC"
diff --git a/src/mainboard/amd/lamar/Kconfig b/src/mainboard/amd/lamar/Kconfig
index 210b3c2..de00225 100644
--- a/src/mainboard/amd/lamar/Kconfig
+++ b/src/mainboard/amd/lamar/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_LAMAR
+	def_bool n
+
 if BOARD_AMD_LAMAR

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/lamar/Kconfig.name b/src/mainboard/amd/lamar/Kconfig.name
index 1831b9a..75eec04 100644
--- a/src/mainboard/amd/lamar/Kconfig.name
+++ b/src/mainboard/amd/lamar/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_LAMAR
-	bool "Lamar"
+# Disabled
+#config BOARD_AMD_LAMAR
+#	bool "Lamar"
diff --git a/src/mainboard/amd/olivehillplus/Kconfig b/src/mainboard/amd/olivehillplus/Kconfig
index 5779aaf..e45ac52 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig
+++ b/src/mainboard/amd/olivehillplus/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_OLIVEHILLPLUS
+	def_bool n
+
 if BOARD_AMD_OLIVEHILLPLUS

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/olivehillplus/Kconfig.name b/src/mainboard/amd/olivehillplus/Kconfig.name
index 85a3e86..1ce4a20 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig.name
+++ b/src/mainboard/amd/olivehillplus/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_OLIVEHILLPLUS
-	bool "Olive Hill Plus"
+# Disabled
+#config BOARD_AMD_OLIVEHILLPLUS
+#	bool "Olive Hill Plus"
diff --git a/src/mainboard/bap/ode_e21XX/Kconfig b/src/mainboard/bap/ode_e21XX/Kconfig
index 3bdb573..e5ae415 100644
--- a/src/mainboard/bap/ode_e21XX/Kconfig
+++ b/src/mainboard/bap/ode_e21XX/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_ODE_E21XX
+	def_bool n
+
 if BOARD_ODE_E21XX

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/bap/ode_e21XX/Kconfig.name b/src/mainboard/bap/ode_e21XX/Kconfig.name
index 5ef8804..64665da 100644
--- a/src/mainboard/bap/ode_e21XX/Kconfig.name
+++ b/src/mainboard/bap/ode_e21XX/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_ODE_E21XX
-	bool "ODE_e21xx"
+# Disabled
+#config BOARD_ODE_E21XX
+#	bool "ODE_e21xx"
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig
index 6c3958b..d10c838 100644
--- a/src/mainboard/pcengines/apu2/Kconfig
+++ b/src/mainboard/pcengines/apu2/Kconfig
@@ -15,6 +15,18 @@
 # GNU General Public License for more details.
 #

+config BOARD_PCENGINES_APU2
+	def_bool n
+
+config BOARD_PCENGINES_APU3
+	def_bool n
+
+config BOARD_PCENGINES_APU4
+	def_bool n
+
+config BOARD_PCENGINES_APU5
+	def_bool n
+
 if BOARD_PCENGINES_APU2 || BOARD_PCENGINES_APU3 || BOARD_PCENGINES_APU4 || \
    BOARD_PCENGINES_APU5

diff --git a/src/mainboard/pcengines/apu2/Kconfig.name b/src/mainboard/pcengines/apu2/Kconfig.name
index 45ec16f..15bdd0b 100644
--- a/src/mainboard/pcengines/apu2/Kconfig.name
+++ b/src/mainboard/pcengines/apu2/Kconfig.name
@@ -1,11 +1,14 @@
-config BOARD_PCENGINES_APU2
-	bool "APU2"
+# Disabled

-config BOARD_PCENGINES_APU3
-	bool "APU3"
+#config BOARD_PCENGINES_APU2
+#	bool "APU2"

-config BOARD_PCENGINES_APU4
-	bool "APU4"
+#config BOARD_PCENGINES_APU3
+#	bool "APU3"

-config BOARD_PCENGINES_APU5
-	bool "APU5"
+#config BOARD_PCENGINES_APU4
+#	bool "APU4"
+
+#config BOARD_PCENGINES_APU5
+#	bool "APU5"
+

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 1:

Kyösti I assume we can proceed with legacy wrapper cleanup, without worrying about mainboards?

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 1: Code-Review+1

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Kyösti I assume we can proceed with legacy wrapper cleanup, without worrying about mainboards?

I saw your comment about POSTCAR_STAGE=y working on apu2. Let's get the tree into condition that we can merge that. You can see how long the CAR_GLOBAL removal patchtrain is on gerrit, BINARYPI_LEGACY_WRAPPER is currently the blocking factor from merging a lot of that.

Let's complete apu2 all the way to C_ENV_BB, capture and combine some good parts from amd/stoneyridge along the way (biosram, some SPI, some bootblock). Only then worry about AGESA or consider re-enabling the other binaryPI platforms and boards.

There is someone on the mailing list with amd/bettong I believe. I can test fam15tn and fam16kb for C_ENV_BB once we get there.

[Kyösti Mälkki (Code Review)]

Hello Piotr Król, Arthur Heymans, build bot (Jenkins), Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37170

to look at the new patch set (#2).

Change subject: binaryPI: Disable boards from build
......................................................................

binaryPI: Disable boards from build

As per the 4.11 release requirement, POSTCAR_STAGE=y
is a mandatory feature, which binaryPI currently lacks.

Disable all binaryPI platforms from the build for the
moment. If a platform does not reach POSTCAR_STAGE=y and
C_ENVIRONMENT_BOOTBLOCK=y within a reasonable timeframe
both the mainboard and the respective (now unused) platform
support code will get removed.

Change-Id: Id81ab0f168034187ecf62203b5a33ac6ba49a35d
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/bettong/Kconfig
M src/mainboard/amd/bettong/Kconfig.name
M src/mainboard/amd/db-ft3b-lc/Kconfig
M src/mainboard/amd/db-ft3b-lc/Kconfig.name
M src/mainboard/amd/lamar/Kconfig
M src/mainboard/amd/lamar/Kconfig.name
M src/mainboard/amd/olivehillplus/Kconfig
M src/mainboard/amd/olivehillplus/Kconfig.name
M src/mainboard/bap/ode_e21XX/Kconfig
M src/mainboard/bap/ode_e21XX/Kconfig.name
10 files changed, 30 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/37170/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG@12 
PS2, Line 12: Disable all binaryPI platforms from the build for the
All except APU2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG@12 
PS2, Line 12: Disable all binaryPI platforms from the build for the
> All except APU2

Couldn't tell whether you intend to update the commit message, or if this is clarification for reviewers.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG@12 
PS2, Line 12: Disable all binaryPI platforms from the build for the
> Couldn't tell whether you intend to update the commit message, or if this is clarification for revie […]

I plan to rebase this series once C_ENV_BB Kconfig flip is merged.

[Kyösti Mälkki (Code Review)]

Hello Piotr Król, Arthur Heymans, Marshall Dawson, build bot (Jenkins), Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37170

to look at the new patch set (#3).

Change subject: binaryPI: Disable boards from build
......................................................................

binaryPI: Disable boards from build

As per the 4.11 release requirement, CAR_GLOBAL_MIGRATION=n is a
mandatory feature, which most binaryPI boards lack as they
use BINARYPI_LEGACY_WRAPPER.

Disable all binaryPI platforms, except pcengines/apu2, from
the build for the time being. If a platform does not reach
POSTCAR_STAGE=y and C_ENVIRONMENT_BOOTBLOCK=y within a
reasonable timeframe both the mainboard and the respective
unused platform support code will get removed.

Change-Id: Id81ab0f168034187ecf62203b5a33ac6ba49a35d
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/bettong/Kconfig
M src/mainboard/amd/bettong/Kconfig.name
M src/mainboard/amd/db-ft3b-lc/Kconfig
M src/mainboard/amd/db-ft3b-lc/Kconfig.name
M src/mainboard/amd/lamar/Kconfig
M src/mainboard/amd/lamar/Kconfig.name
M src/mainboard/amd/olivehillplus/Kconfig
M src/mainboard/amd/olivehillplus/Kconfig.name
M src/mainboard/bap/ode_e21XX/Kconfig
M src/mainboard/bap/ode_e21XX/Kconfig.name
10 files changed, 30 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/37170/3

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 3: Code-Review+1

I'll probably +2 once you have rebased... just want some time to think if there'll be any negative issue from this, though right now I can't see any... those are all old platforms.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37170/2//COMMIT_MSG@12 
PS2, Line 12: Disable all binaryPI platforms from the build for the
> I plan to rebase this series once C_ENV_BB Kconfig flip is merged.

Done

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 3: Code-Review+2

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

Patch Set 3: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37170 )

Change subject: binaryPI: Disable boards from build
......................................................................

binaryPI: Disable boards from build

As per the 4.11 release requirement, CAR_GLOBAL_MIGRATION=n is a
mandatory feature, which most binaryPI boards lack as they
use BINARYPI_LEGACY_WRAPPER.

Disable all binaryPI platforms, except pcengines/apu2, from
the build for the time being. If a platform does not reach
POSTCAR_STAGE=y and C_ENVIRONMENT_BOOTBLOCK=y within a
reasonable timeframe both the mainboard and the respective
unused platform support code will get removed.

Change-Id: Id81ab0f168034187ecf62203b5a33ac6ba49a35d
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37170
Tested-by: build bot (Jenkins) 
Reviewed-by: Richard Spiegel 
Reviewed-by: Arthur Heymans 
Reviewed-by: Michał Żygowski 
---
M src/mainboard/amd/bettong/Kconfig
M src/mainboard/amd/bettong/Kconfig.name
M src/mainboard/amd/db-ft3b-lc/Kconfig
M src/mainboard/amd/db-ft3b-lc/Kconfig.name
M src/mainboard/amd/lamar/Kconfig
M src/mainboard/amd/lamar/Kconfig.name
M src/mainboard/amd/olivehillplus/Kconfig
M src/mainboard/amd/olivehillplus/Kconfig.name
M src/mainboard/bap/ode_e21XX/Kconfig
M src/mainboard/bap/ode_e21XX/Kconfig.name
10 files changed, 30 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Richard Spiegel: Looks good to me, but someone else must approve
  Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/amd/bettong/Kconfig b/src/mainboard/amd/bettong/Kconfig
index 5f26e87..bcfceb1 100644
--- a/src/mainboard/amd/bettong/Kconfig
+++ b/src/mainboard/amd/bettong/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_BETTONG
+	def_bool n
+
 if BOARD_AMD_BETTONG

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/bettong/Kconfig.name b/src/mainboard/amd/bettong/Kconfig.name
index 09201b5..4bd1329 100644
--- a/src/mainboard/amd/bettong/Kconfig.name
+++ b/src/mainboard/amd/bettong/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_BETTONG
-	bool "Bettong"
+# Disabled
+#config BOARD_AMD_BETTONG
+#	bool "Bettong"
diff --git a/src/mainboard/amd/db-ft3b-lc/Kconfig b/src/mainboard/amd/db-ft3b-lc/Kconfig
index 256b555..eaee3e7 100644
--- a/src/mainboard/amd/db-ft3b-lc/Kconfig
+++ b/src/mainboard/amd/db-ft3b-lc/Kconfig
@@ -14,6 +14,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_DB_FT3B_LC
+	def_bool n
+
 if BOARD_AMD_DB_FT3B_LC

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/db-ft3b-lc/Kconfig.name b/src/mainboard/amd/db-ft3b-lc/Kconfig.name
index 7caf95d..3197a70 100644
--- a/src/mainboard/amd/db-ft3b-lc/Kconfig.name
+++ b/src/mainboard/amd/db-ft3b-lc/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_DB_FT3B_LC
-	bool "DB-FT3b-LC"
+# Disabled
+#config BOARD_AMD_DB_FT3B_LC
+#	bool "DB-FT3b-LC"
diff --git a/src/mainboard/amd/lamar/Kconfig b/src/mainboard/amd/lamar/Kconfig
index 025e5ff..5527d59 100644
--- a/src/mainboard/amd/lamar/Kconfig
+++ b/src/mainboard/amd/lamar/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_LAMAR
+	def_bool n
+
 if BOARD_AMD_LAMAR

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/lamar/Kconfig.name b/src/mainboard/amd/lamar/Kconfig.name
index 1831b9a..75eec04 100644
--- a/src/mainboard/amd/lamar/Kconfig.name
+++ b/src/mainboard/amd/lamar/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_LAMAR
-	bool "Lamar"
+# Disabled
+#config BOARD_AMD_LAMAR
+#	bool "Lamar"
diff --git a/src/mainboard/amd/olivehillplus/Kconfig b/src/mainboard/amd/olivehillplus/Kconfig
index 96d9347..61ba33d 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig
+++ b/src/mainboard/amd/olivehillplus/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_AMD_OLIVEHILLPLUS
+	def_bool n
+
 if BOARD_AMD_OLIVEHILLPLUS

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/olivehillplus/Kconfig.name b/src/mainboard/amd/olivehillplus/Kconfig.name
index 85a3e86..1ce4a20 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig.name
+++ b/src/mainboard/amd/olivehillplus/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_AMD_OLIVEHILLPLUS
-	bool "Olive Hill Plus"
+# Disabled
+#config BOARD_AMD_OLIVEHILLPLUS
+#	bool "Olive Hill Plus"
diff --git a/src/mainboard/bap/ode_e21XX/Kconfig b/src/mainboard/bap/ode_e21XX/Kconfig
index bf812f2..5b0d2fb 100644
--- a/src/mainboard/bap/ode_e21XX/Kconfig
+++ b/src/mainboard/bap/ode_e21XX/Kconfig
@@ -13,6 +13,9 @@
 # GNU General Public License for more details.
 #

+config BOARD_ODE_E21XX
+	def_bool n
+
 if BOARD_ODE_E21XX

config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/bap/ode_e21XX/Kconfig.name b/src/mainboard/bap/ode_e21XX/Kconfig.name
index 5ef8804..64665da 100644
--- a/src/mainboard/bap/ode_e21XX/Kconfig.name
+++ b/src/mainboard/bap/ode_e21XX/Kconfig.name
@@ -1,2 +1,3 @@
-config BOARD_ODE_E21XX
-	bool "ODE_e21xx"
+# Disabled
+#config BOARD_ODE_E21XX
+#	bool "ODE_e21xx"