Attention is currently required from: Felix Held, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 20:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83719/comment/9933304f_e41562b0?usp... : PS18, Line 11: 8GB LPDDR5 memory
if you have the information, please note the vendor/model too.
Okay, Update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/a16346ea_fd98f0f2?usp... : PS18, Line 28: - Windows 11 boot from eMMC
Also install?
Yes. use Ventoy to install Ubuntu 24.04 on NVMe SSD from USB Disk passed keep original Windows 11 on EMMC for dual boot passed
https://review.coreboot.org/c/coreboot/+/83719/comment/bcdaf853_ca06fb60?usp... : PS18, Line 32: - HDMI output
What about audio? Does it work over HDMI?
Okay, I tested Audio over HDMI workable with Ubuntu 24.04, but Windows 11 not support
https://review.coreboot.org/c/coreboot/+/83719/comment/b2500f02_9bcbd3e8?usp... : PS18, Line 33: Realtek Ethernet
Which is it?
Okay, I see the CHIP is RTL8111H-CG-RH
https://review.coreboot.org/c/coreboot/+/83719/comment/6063eb44_08234d5a?usp... : PS18, Line 38: BSOD
It’d be great if you mentioned the “id”/output of the BSOD.
okay, it is 'Machine Check Exception'
https://review.coreboot.org/c/coreboot/+/83719/comment/0bcfc5b9_6e350ed2?usp... : PS18, Line 43:
Do you have some timeing numbers? Vendor firmware until boot loader and coreboot (with MRC cache) un […]
How to measurement the timing? if you can tell me, I will try it.
File src/mainboard/lattepanda/mu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/11142408_f28657bf?usp... : PS18, Line 27: UEFITOOLS
UEFITool
Okay, Update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/3919fa10_263241cb?usp... : PS18, Line 38: static const struct initdata it8613e_initdata[]
Just one space after `initdata`.
Okay, Update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/2e66d657_e03b2e53?usp... : PS18, Line 64: initdata it8613e_ecdata[]
Ditto.
Okay, Update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/c54ec154_624b392f?usp... : PS18, Line 95: u16
size_t?
great suggestion. update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/0ee3eb21_b97c6eb8?usp... : PS18, Line 99: u16
`unsigned int` or `size_t`
okay, update in latest patch
https://review.coreboot.org/c/coreboot/+/83719/comment/db27d8fd_0cfc2fd5?usp... : PS18, Line 102: if (table[i].OpAnd == 0) : val = table[i].OpOr; : else { : val = ((inb(p_dat) & table[i].OpAnd) | : table[i].OpOr); : }
Please use curly brackets for both branches or no brackets.
okay, update in latest patch