Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74474?usp=email )
Change subject: util: Use common ARRAY_SIZE define
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
other parts of src/commonlib being used in util/ is another very strong argument for this. […]
had a brief discussion about this in the last coreboot leadership meeting and the idea of commonlib was about being able to easily share header files between src/ and the utilities in util/, so the utils should use commonlib instead of having their own definitions. at least now i know for sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74474?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29b776586b4f0548d4026b2ac77095791fc9f3a3
Gerrit-Change-Number: 74474
Gerrit-PatchSet: 4
Gerrit-Owner: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 21:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konrad Adamczyk
konrada@google.com
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment