Attention is currently required from: Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80598?usp=email )
Change subject: device/pnp_device: Skip init on disabled functions ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80598/comment/b15ab7fc_98724f9b : PS1, Line 11: any resources to that function.
The code disabled here merely attaches the structures for the […]
I figured kneecapping it earliest was best
https://review.coreboot.org/c/coreboot/+/80598/comment/6100aacf_69eb2936 : PS1, Line 15: in the log / don't cause any errors.
Can you share a log? errors are often because of mistakes in the […]
[DEBUG] PNP: 002e.1 60 <- [0x00000000000003f8 - 0x00000000000003ff] size 0x00000008 gran 0x03 io [DEBUG] PNP: 002e.1 70 <- [0x0000000000000004 - 0x0000000000000004] size 0x00000001 gran 0x00 irq [DEBUG] PNP: 002e.10 62 <- [0x0000000000000360 - 0x0000000000000361] size 0x00000002 gran 0x01 io [ERROR] PNP: 002e.10 60 io size: 0x0000000002 not assigned in devicetree [ERROR] PNP: 002e.10 64 io size: 0x0000000002 not assigned in devicetree [ERROR] PNP: 002e.10 66 io size: 0x0000000002 not assigned in devicetree [ERROR] PNP: 002e.10 70 irq size: 0x0000000001 not assigned in devicetree [DEBUG] LPC: enabling default decode range LPC_IOE_COMA_EN [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0! [ERROR] LPC IO decode base 0!
best I can tell, the errors all stem from the IO bases of the various disabled functions being 0. With this patch, all but 3 of the 'decode base 0' errors are removed (those are from the RTC, which has 3 IO windows un-set / defaulting to 0).
File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/80598/comment/31983cae_5ca7b7a5 : PS1, Line 403: dev->ops = ops;
Not setting the ops has certain side effects. For instance one couldn't generate […]
where do we generate SSDT entries for disabled devices?