Change in ...coreboot[master]: {cpu,device,drivers}: Remove unused include <device/pci_ops.h>
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33527
Change subject: {cpu,device,drivers}: Remove unused include <device/pci_ops.h> ......................................................................
{cpu,device,drivers}: Remove unused include <device/pci_ops.h>
Change-Id: I68da75e3afa2f66aff9961728d4a76bc3e175fce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/pi/amd_late_init.c M src/cpu/intel/fsp_model_406dx/bootblock.c M src/device/azalia_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/intel/gma/intel_ddi.c 5 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33527/1
diff --git a/src/cpu/amd/pi/amd_late_init.c b/src/cpu/amd/pi/amd_late_init.c index 8c0da9d..e105892 100644 --- a/src/cpu/amd/pi/amd_late_init.c +++ b/src/cpu/amd/pi/amd_late_init.c @@ -17,7 +17,6 @@ #include <bootstate.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h>
#include <northbridge/amd/pi/agesawrapper.h> #include <northbridge/amd/pi/agesawrapper_call.h> diff --git a/src/cpu/intel/fsp_model_406dx/bootblock.c b/src/cpu/intel/fsp_model_406dx/bootblock.c index 14cfad9..c43124a 100644 --- a/src/cpu/intel/fsp_model_406dx/bootblock.c +++ b/src/cpu/intel/fsp_model_406dx/bootblock.c @@ -20,7 +20,6 @@ #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <arch/io.h> -#include <device/pci_ops.h> #include <southbridge/intel/fsp_rangeley/soc.h>
#include "model_406dx.h" diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index a2849b7..9727eb6 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/azalia_device.h> #include <device/mmio.h> #include <delay.h> diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 21af5c7..59659b8 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <pc80/vga.h>
#include "../common/aspeed_coreboot.h" diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 471a5d2..b475b5e 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -30,7 +30,6 @@ #include <stdlib.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h> #include <console/console.h> #include <arch/acpi.h> #include <arch/interrupt.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33527
to look at the new patch set (#2).
Change subject: {cpu,device,drivers}: Remove unused include <device/pci_ops.h> ......................................................................
{cpu,device,drivers}: Remove unused include <device/pci_ops.h>
Change-Id: I68da75e3afa2f66aff9961728d4a76bc3e175fce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/pi/amd_late_init.c M src/device/azalia_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/intel/gma/intel_ddi.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33527/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33527 )
Change subject: {cpu,device,drivers}: Remove unused include <device/pci_ops.h> ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33527 )
Change subject: {cpu,device,drivers}: Remove unused include <device/pci_ops.h> ......................................................................
{cpu,device,drivers}: Remove unused include <device/pci_ops.h>
Change-Id: I68da75e3afa2f66aff9961728d4a76bc3e175fce Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33527 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/amd/pi/amd_late_init.c M src/device/azalia_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/intel/gma/intel_ddi.c 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/cpu/amd/pi/amd_late_init.c b/src/cpu/amd/pi/amd_late_init.c index 35ce3af..46144c6 100644 --- a/src/cpu/amd/pi/amd_late_init.c +++ b/src/cpu/amd/pi/amd_late_init.c @@ -15,7 +15,6 @@ #include <bootstate.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h>
#include <northbridge/amd/pi/agesawrapper.h> #include <northbridge/amd/pi/agesawrapper_call.h> diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index a2849b7..9727eb6 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/azalia_device.h> #include <device/mmio.h> #include <delay.h> diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 21af5c7..59659b8 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_ops.h> #include <pc80/vga.h>
#include "../common/aspeed_coreboot.h" diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 3ab0022..9e9bd972 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -30,7 +30,6 @@ #include <stdlib.h> #include <device/device.h> #include <device/pci_def.h> -#include <device/pci_ops.h> #include <console/console.h> #include <arch/acpi.h> #include <boot/coreboot_tables.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)