Attention is currently required from: Felix Held, Jérémy Compostella.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80335?usp=email )
Change subject: cpu/x86/(sipi|smm): Pass on CR3 from ramstage
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/80335/comment/dca7b5b1_3c23f783 :
PS4, Line 366: sp->cr3 = read_cr3();
i wonder if this is really needed to only be run depending on ENV_X86_64. at least to me it seems that it wouldn't hurt to also do that in the ENV_X86_32 case and it would be a bit more consistent
Only the 64bit codepath uses it. I suppose it won't hurt to just read it on 32bit either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80335?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1250ea6f63c65228178ee66e06d988dadfcc2a37
Gerrit-Change-Number: 80335
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 09 Feb 2024 14:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment