Change in coreboot[master]: soc/intel/cannonlake: Correct the return data type as per pci_devfn_t
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the return data type as per pci_devfn_t ......................................................................
soc/intel/cannonlake: Correct the return data type as per pci_devfn_t
Change-Id: Id974a4bb84b7d5caddece04f93bf4e830d15b576 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34466/1
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index cbaa710..6fb3060 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -26,7 +26,7 @@
#include "chip.h"
-static const int serial_io_dev[] = { +static const pci_devfn_t serial_io_dev[] = { PCH_DEVFN_I2C0, PCH_DEVFN_I2C1, PCH_DEVFN_I2C2,
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the return data type as per pci_devfn_t ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the return data type as per pci_devfn_t ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/34466/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34466/1//COMMIT_MSG@7 PS1, Line 7: Correct the return data type as per pci_devfn_t The commit message does not really reflect the actual change being made in this CL.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the return data type as per pci_devfn_t ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has uploaded a new patch set (#2) to the change originally created by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the data type of serial_io_dev ......................................................................
soc/intel/cannonlake: Correct the data type of serial_io_dev
Change-Id: Id974a4bb84b7d5caddece04f93bf4e830d15b576 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34466/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the data type of serial_io_dev ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34466
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Correct the data type of serial_io_dev ......................................................................
soc/intel/cannonlake: Correct the data type of serial_io_dev
Change-Id: Id974a4bb84b7d5caddece04f93bf4e830d15b576 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34466/3
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the data type of serial_io_dev ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34466/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34466/1//COMMIT_MSG@7 PS1, Line 7: Correct the return data type as per pci_devfn_t
The commit message does not really reflect the actual change being made in this CL.
Done
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34466 )
Change subject: soc/intel/cannonlake: Correct the data type of serial_io_dev ......................................................................
soc/intel/cannonlake: Correct the data type of serial_io_dev
Change-Id: Id974a4bb84b7d5caddece04f93bf4e830d15b576 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34466 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index cbaa710..6fb3060 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -26,7 +26,7 @@
#include "chip.h"
-static const int serial_io_dev[] = { +static const pci_devfn_t serial_io_dev[] = { PCH_DEVFN_I2C0, PCH_DEVFN_I2C1, PCH_DEVFN_I2C2,
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Tim Wawrzynczak (Code Review)