Attention is currently required from: Furquan Shaikh, Jeff Chase, Tim Wawrzynczak, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57037 )
Change subject: mb/google/hatch: don't override variant_ramstage_init() in baseboard
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Alternatively, you can also:
Add two separate files: mainboard_hatch.c and mainboard_puff.c in variants/baseboard/hatch. These can be included based on CONFIG_BOARD_GOOGLE_BASEBOARD_HATCH and CONFIG_BOARD_GOOGLE_BASEBOARD_PUFF.
Each of these mainboard file will provide a weak definition of `variant_ramstage_init()`. For hatch, it will be empty. For puff, it will do what it is currently doing i.e. power limit + other configuration.
For the puff variants that you care about doing things differently, you can add non-weak implementation of `variant_ramstage_init()`.
+1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57037
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e787c3d4c2f2c62a0dc868997b6e4c3da84c43
Gerrit-Change-Number: 57037
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Chase
jnchase@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Joe Tessler
jrt@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jeff Chase
jnchase@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sun, 22 Aug 2021 06:11:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Jeff Chase
jnchase@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment