Attention is currently required from: Boris Mittelberg, Caveh Jalali, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85743?usp=email )
Change subject: ec/google/chromeec: Add API to check if a USB PD charger is attached
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/85743/comment/a32c86b5_34ae9b30?usp... :
PS3, Line 985: if (resp.type == USB_CHG_TYPE_PD)
Could be `return resp.type == USB_CHG_TYPE_PD;`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923
Gerrit-Change-Number: 85743
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 26 Dec 2024 18:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No